Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2841)

Unified Diff: build/android/buildbot/bb_run_bot.py

Issue 727543003: [Android] Fix new pylint errors in build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/buildbot/bb_device_steps.py ('k') | build/android/install_emulator_deps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_run_bot.py
diff --git a/build/android/buildbot/bb_run_bot.py b/build/android/buildbot/bb_run_bot.py
index 8c853e76f640e12c93afc7d90b1ee04d076b5ec2..abdd2bec26adc2d33b00879d1c07506fdb03a09f 100755
--- a/build/android/buildbot/bb_run_bot.py
+++ b/build/android/buildbot/bb_run_bot.py
@@ -132,10 +132,10 @@ def GetBotStepMap():
os.path.join(os.path.dirname(__file__), os.pardir, os.pardir, os.pardir,
os.pardir, 'bisect', 'src', 'out'))
B = BotConfig
- H = (lambda steps, extra_args=None, extra_gyp=None, target_arch=None :
+ H = (lambda steps, extra_args=None, extra_gyp=None, target_arch=None:
HostConfig('build/android/buildbot/bb_host_steps.py', steps, extra_args,
extra_gyp, target_arch))
- T = (lambda tests, extra_args=None :
+ T = (lambda tests, extra_args=None:
TestConfig('build/android/buildbot/bb_device_steps.py', tests,
extra_args))
@@ -150,7 +150,7 @@ def GetBotStepMap():
T(std_tests + telemetry_tests + chrome_proxy_tests,
['--cleanup', flakiness_server])),
B('main-tests', H(std_test_steps),
- T(std_tests,['--cleanup', flakiness_server])),
+ T(std_tests, ['--cleanup', flakiness_server])),
# Other waterfalls
B('asan-builder-tests', H(compile_step,
@@ -167,7 +167,7 @@ def GetBotStepMap():
extra_gyp='emma_coverage=1')),
B('x86-builder-dbg',
H(compile_step + std_host_tests, target_arch='ia32')),
- B('fyi-builder-rel', H(std_build_steps, experimental)),
+ B('fyi-builder-rel', H(std_build_steps, experimental)),
B('fyi-tests', H(std_test_steps),
T(std_tests + python_unittests,
['--experimental', flakiness_server,
@@ -234,7 +234,7 @@ def GetBotStepMap():
def GetBestMatch(id_map, id):
config = id_map.get(id)
if not config:
- substring_matches = filter(lambda x: x in id, id_map.iterkeys())
+ substring_matches = [x for x in id_map.iterkeys() if x in id]
if substring_matches:
max_id = max(substring_matches, key=len)
print 'Using config from id="%s" (substring match).' % max_id
« no previous file with comments | « build/android/buildbot/bb_device_steps.py ('k') | build/android/install_emulator_deps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698