Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 727543003: [Android] Fix new pylint errors in build/android/. (Closed)

Created:
6 years, 1 month ago by jbudorick
Modified:
6 years, 1 month ago
Reviewers:
klundberg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, perezju, rnephew (Reviews Here), mikecase (-- gone --)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix new pylint errors in build/android/. BUG=434544 Committed: https://crrev.com/0f77e966d5fa7d854772e63a64d0ab518c2bd3e8 Cr-Commit-Position: refs/heads/master@{#304812}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -101 lines) Patch
M build/android/adb_logcat_monitor.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/avd.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 4 chunks +5 lines, -5 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 4 chunks +5 lines, -5 lines 0 comments Download
M build/android/install_emulator_deps.py View 6 chunks +7 lines, -7 lines 0 comments Download
M build/android/provision_devices.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/base/base_test_result.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/adb_wrapper.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/device/decorators_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 3 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 6 chunks +18 lines, -26 lines 0 comments Download
M build/android/pylib/gtest/test_runner.py View 1 chunk +6 lines, -6 lines 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 2 chunks +3 lines, -2 lines 0 comments Download
M build/android/pylib/linker/setup.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/pylib/linker/test_case.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/linker/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/perf/surface_stats_collector.py View 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/utils/host_path_finder.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/pylib/utils/json_results_generator.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/utils/parallelizer.py View 2 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/utils/report_results.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/symbolize.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
triggered by the pylint upgrade described in https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/YMVCfTSiQIg
6 years, 1 month ago (2014-11-19 00:09:48 UTC) #2
klundberg
lgtm Thanks for fixing all these, John!!
6 years, 1 month ago (2014-11-19 04:59:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727543003/20001
6 years, 1 month ago (2014-11-19 14:31:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-19 15:41:38 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 15:42:41 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0f77e966d5fa7d854772e63a64d0ab518c2bd3e8
Cr-Commit-Position: refs/heads/master@{#304812}

Powered by Google App Engine
This is Rietveld 408576698