Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 727533004: Keyboard shortcut for 'Back','Forward' and 'Save page' are not present. (Closed)

Created:
6 years, 1 month ago by Deepak
Modified:
6 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Keyboard shortcut for 'Back','Forward' and 'Save page' are not present. keyboard shortcuts are not mentioned with 'Back','Forward' and 'Save page' in context menu. Keyboard shortcut's should be shown, so that user can do these operation via keyboard also. Changes done for adding info for keyboard shortcuts. BUG=435036 Committed: https://crrev.com/e5eb027f40c10856870fb024320060b7f6a42267 Cr-Commit-Position: refs/heads/master@{#305180}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Changes as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Deepak
Followup for previous issue for providing Accelerator key's for menu items. AFAIK with this patch ...
6 years, 1 month ago (2014-11-20 10:31:15 UTC) #2
msw
https://codereview.chromium.org/727533004/diff/1/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc File chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc (right): https://codereview.chromium.org/727533004/diff/1/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc#newcode114 chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc:114: case IDC_SAVE_PAGE: Put this in alphabetical order (after IDC_RELOAD).
6 years, 1 month ago (2014-11-20 17:36:46 UTC) #3
Deepak
On 2014/11/20 17:36:46, msw wrote: > https://codereview.chromium.org/727533004/diff/1/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc > File > chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc > (right): > > ...
6 years, 1 month ago (2014-11-21 02:42:36 UTC) #4
msw
lgtm
6 years, 1 month ago (2014-11-21 05:25:04 UTC) #5
Deepak
On 2014/11/21 05:25:04, msw wrote: > lgtm Thanks.
6 years, 1 month ago (2014-11-21 05:29:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727533004/20001
6 years, 1 month ago (2014-11-21 05:30:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-21 06:16:57 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 06:17:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5eb027f40c10856870fb024320060b7f6a42267
Cr-Commit-Position: refs/heads/master@{#305180}

Powered by Google App Engine
This is Rietveld 408576698