Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 727483002: PropertyAccessCompiler should always emit reloc info for external references. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

PropertyAccessCompiler should always emit reloc info for external references. R=mvstanton@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/bf8abc3e1ec584512ecc8ec3d64b02b0a91b8d07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/ic/access-compiler.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 1 month ago (2014-11-13 15:25:52 UTC) #1
Yang
On 2014/11/13 15:25:52, Yang wrote: When v8 x64 is compiled without snapshot, LoadIC_Miss is created ...
6 years, 1 month ago (2014-11-13 15:27:29 UTC) #2
mvstanton
lgtm
6 years, 1 month ago (2014-11-13 15:33:39 UTC) #3
Yang
6 years, 1 month ago (2014-11-13 15:37:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf8abc3e1ec584512ecc8ec3d64b02b0a91b8d07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698