Keep the original index of password list items when filtering, so the right password can be deleted.

chrome/browser/resources/options/password_manager.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   const OptionsPage = options.OptionsPage;
   const ArrayDataModel = cr.ui.ArrayDataModel;
 
   /////////////////////////////////////////////////////////////////////////////
   // PasswordManager class:
@@ skipping 135 matching lines @@
     /**
      * Updates the data model for the saved passwords list with the values from
      * |entries|.
      * @param {Array} entries The list of saved password data.
      */
     setSavedPasswordsList_: function(entries) {
       if (this.lastQuery_) {
         // Implement password searching here in javascript, rather than in C++.
         // The number of saved passwords shouldn't be too big for us to handle.
         var query = this.lastQuery_;
-        var filter = function(entry) {
+        var filter = function(entry, index, list) {

[James Hawkins, 2011/06/28 01:27:18]

|list| is unused?

[Mike Mammarella, 2011/06/28 01:30:27]

Correct, but it's apparently passed so I included it here.

[James Hawkins, 2011/06/28 01:31:22]

Can't we not include it, like we did before?

[Mike Mammarella, 2011/06/28 01:34:19]

We could, but I almost rewrote this by hand just because I needed the index
parameter and didn't realize that it was available. I figure it's worth the
self-documentation.

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/fi...
says it's there.

           // Search both URL and username.
-          return entry[0].indexOf(query) >= 0 || entry[1].indexOf(query) >= 0;
+          if (entry[0].indexOf(query) >= 0 || entry[1].indexOf(query) >= 0) {
+            // Keep the original index so we can delete correctly. See also
+            // deleteItemAtIndex() in password_manager_list.js that uses this.
+            entry[3] = index;
+            return true;
+          }
+          return false;
         };
         entries = entries.filter(filter);
       }
       this.savedPasswordsList_.dataModel = new ArrayDataModel(entries);
       this.updateListVisibility_(this.savedPasswordsList_);
     },
 
     /**
      * Updates the data model for the password exceptions list with the values
      * from |entries|.
@@ skipping 44 matching lines @@
   PasswordManager.setPasswordExceptionsList = function(entries) {
     PasswordManager.getInstance().setPasswordExceptionsList_(entries);
   };
 
   // Export
   return {
     PasswordManager: PasswordManager
   };
 
 });