Keep the original index of password list items when filtering, so the right password can be deleted.

Keep the original index of password list items when filtering, so the right password can be deleted. (Instead of some random other password!)
BUG=87221
TEST=deleteting passwords when the password list is filtered (searched) works correctly
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90695

[Mike Mammarella, 2011-06-28 01:24:36]

This should be merged to all relevant branches.

[James Hawkins, 2011-06-28 01:27:18]

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/password_manager.js (right):

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/password_manager.js:156: var filter =
function(entry, index, list) {
|list| is unused?

[Mike Mammarella, 2011-06-28 01:30:26]

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/password_manager.js (right):

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/password_manager.js:156: var filter =
function(entry, index, list) {
On 2011/06/28 01:27:18, James Hawkins wrote:
> |list| is unused?

Correct, but it's apparently passed so I included it here.

[James Hawkins, 2011-06-28 01:31:22]

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/password_manager.js (right):

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/password_manager.js:156: var filter =
function(entry, index, list) {
On 2011/06/28 01:30:27, Mike Mammarella wrote:
> On 2011/06/28 01:27:18, James Hawkins wrote:
> > |list| is unused?
> 
> Correct, but it's apparently passed so I included it here.

Can't we not include it, like we did before?

[Mike Mammarella, 2011-06-28 01:34:19]

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/password_manager.js (right):

http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/password_manager.js:156: var filter =
function(entry, index, list) {
On 2011/06/28 01:31:22, James Hawkins wrote:
> On 2011/06/28 01:30:27, Mike Mammarella wrote:
> > On 2011/06/28 01:27:18, James Hawkins wrote:
> > > |list| is unused?
> > 
> > Correct, but it's apparently passed so I included it here.
> 
> Can't we not include it, like we did before?

We could, but I almost rewrote this by hand just because I needed the index
parameter and didn't realize that it was available. I figure it's worth the
self-documentation.

https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/fi...
says it's there.

[James Hawkins, 2011-06-28 01:37:15]

On 2011/06/28 01:34:19, Mike Mammarella wrote:
>
http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
> File chrome/browser/resources/options/password_manager.js (right):
> 
>
http://codereview.chromium.org/7274015/diff/1/chrome/browser/resources/option...
> chrome/browser/resources/options/password_manager.js:156: var filter =
> function(entry, index, list) {
> On 2011/06/28 01:31:22, James Hawkins wrote:
> > On 2011/06/28 01:30:27, Mike Mammarella wrote:
> > > On 2011/06/28 01:27:18, James Hawkins wrote:
> > > > |list| is unused?
> > > 
> > > Correct, but it's apparently passed so I included it here.
> > 
> > Can't we not include it, like we did before?
> 
> We could, but I almost rewrote this by hand just because I needed the index
> parameter and didn't realize that it was available. I figure it's worth the
> self-documentation.
> 
>
https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/fi...
> says it's there.

OK, LGTM