Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 727373002: [turbofan] add ForTesting to pipeline entry points that are for testing only. (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] add ForTesting to pipeline entry points that are for testing only. R=bmeurer@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/e01f34b5cc0863c130252d52c651200272320ce7

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -44 lines) Patch
M src/compiler/pipeline.h View 1 2 3 chunks +20 lines, -7 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 chunks +38 lines, -18 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
dcarney
ptal
6 years, 1 month ago (2014-11-17 14:36:37 UTC) #2
Benedikt Meurer
LGTM, go ahead! :-)
6 years, 1 month ago (2014-11-17 14:44:28 UTC) #3
dcarney
6 years, 1 month ago (2014-11-17 14:47:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
e01f34b5cc0863c130252d52c651200272320ce7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698