Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 727343002: move SkPDFD*.h from include to src (Closed)

Created:
6 years, 1 month ago by hal.canary
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org, djsollen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move SkPDFD*.h from include to src CQ_INCLUDE_TRYBOTS=client.skia:Mac Builder-Trybot,Linux Builder-Trybot,Win Builder-Trybot Committed: https://skia.googlesource.com/skia/+/07327bff1bb4ced2a35af0a5b0227c0b2cd8ac32

Patch Set 1 #

Patch Set 2 : Another Patch Set #

Patch Set 3 : Another Patch Set #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -456 lines) Patch
M gyp/pdf.gyp View 3 2 chunks +1 line, -2 lines 0 comments Download
M gyp/pdf.gypi View 1 2 3 3 chunks +4 lines, -6 lines 0 comments Download
M gyp/tools.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D include/pdf/SkPDFDevice.h View 1 2 3 1 chunk +0 lines, -336 lines 0 comments Download
D include/pdf/SkPDFDocument.h View 1 chunk +0 lines, -113 lines 0 comments Download
A + src/pdf/SkPDFDevice.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFDocument.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hal.canary
PTAL.
6 years, 1 month ago (2014-11-17 11:29:34 UTC) #2
reed1
lgtm
6 years, 1 month ago (2014-11-17 14:15:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727343002/1
6 years, 1 month ago (2014-11-17 14:16:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/693024300f79ff3fb497ddee1043b609ddf521a4
6 years, 1 month ago (2014-11-17 14:26:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727343002/60001
5 years, 10 months ago (2015-02-19 14:44:44 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 15:26:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/07327bff1bb4ced2a35af0a5b0227c0b2cd8ac32

Powered by Google App Engine
This is Rietveld 408576698