Issue 72733002: [cr tool] Adding the concept of a target platform.

lgtm, thanks! https://codereview.chromium.org/72733002/diff/40001/tools/cr/cr/base/platform.py File tools/cr/cr/base/platform.py (right): https://codereview.chromium.org/72733002/diff/40001/tools/cr/cr/base/platform.py#newcode65 tools/cr/cr/base/platform.py:65: if entry.endswith(os.path.sep+'goma'): nit: space around +

7 years, 1 month ago (2013-11-15 17:57:49 UTC) #2

ian_cottrell

https://codereview.chromium.org/72733002/diff/40001/tools/cr/cr/base/platform.py File tools/cr/cr/base/platform.py (right): https://codereview.chromium.org/72733002/diff/40001/tools/cr/cr/base/platform.py#newcode65 tools/cr/cr/base/platform.py:65: if entry.endswith(os.path.sep+'goma'): On 2013/11/15 17:57:50, bulach wrote: > nit: ...

7 years, 1 month ago (2013-11-18 12:00:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iancottrell@chromium.org/72733002/80001

7 years, 1 month ago (2013-11-18 12:01:18 UTC) #4

Message was sent while issue was closed.

Change committed as 235743

Expand Messages | Collapse Messages

Issue 72733002: [cr tool] Adding the concept of a target platform. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use os.path.join directly #

Patch Set 3 : Add whitespace #

Messages