Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 727323004: Distinguish beween final incremental mark-compact and full mark-compact event in IdleNotification. (Closed)

Created:
6 years, 1 month ago by Hannes Payer (out of office)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Distinguish beween final incremental mark-compact and full mark-compact event in IdleNotification. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -35 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 2 3 4 5 6 7 4 chunks +17 lines, -0 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 3 4 5 4 chunks +25 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 1 2 3 4 5 10 chunks +41 lines, -8 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 3 4 5 8 chunks +53 lines, -21 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 3 chunks +7 lines, -4 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Hannes Payer (out of office)
6 years ago (2014-11-24 09:16:33 UTC) #2
Hannes Payer (out of office)
In a follow up cl, finalize incremental marking will not increase the mark_compacts_since_idle_round_started_ and will ...
6 years ago (2014-11-24 15:32:24 UTC) #3
ulan
Looks good, one question: https://codereview.chromium.org/727323004/diff/60001/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/727323004/diff/60001/src/heap/gc-idle-time-handler.cc#newcode162 src/heap/gc-idle-time-handler.cc:162: EstimateMarkCompactTime( EstimateFinalIncrementalMarkCompactTime?
6 years ago (2014-11-24 16:02:28 UTC) #4
Hannes Payer (out of office)
https://codereview.chromium.org/727323004/diff/60001/src/heap/gc-idle-time-handler.cc File src/heap/gc-idle-time-handler.cc (right): https://codereview.chromium.org/727323004/diff/60001/src/heap/gc-idle-time-handler.cc#newcode162 src/heap/gc-idle-time-handler.cc:162: EstimateMarkCompactTime( On 2014/11/24 16:02:28, ulan wrote: > EstimateFinalIncrementalMarkCompactTime? Done.
6 years ago (2014-11-24 19:05:09 UTC) #5
ulan
lgtm
6 years ago (2014-11-25 09:45:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727323004/80001
6 years ago (2014-11-25 12:31:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1287) v8_mac_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1502)
6 years ago (2014-11-25 12:33:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727323004/140001
6 years ago (2014-11-25 13:13:51 UTC) #12
commit-bot: I haz the power
6 years ago (2014-11-25 13:41:52 UTC) #13
Message was sent while issue was closed. 
Committed patchset #8 (id:140001)

Powered by Google App Engine
This is Rietveld 408576698