Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 727323002: [turbofan] move register allocation phases to pipeline (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] move register allocation phases to pipeline BUG= R=bmeurer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/032191e9be484343d54f50e41b28459634c99aa1

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -249 lines) Patch
M src/compiler/pipeline.h View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 17 chunks +232 lines, -122 lines 1 comment Download
M src/compiler/register-allocator.h View 1 2 5 chunks +28 lines, -15 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 chunks +6 lines, -54 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 1 chunk +3 lines, -31 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 4 chunks +3 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Benedikt Meurer
https://codereview.chromium.org/727323002/diff/40001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/727323002/diff/40001/src/compiler/pipeline.cc#newcode94 src/compiler/pipeline.cc:94: void Initialize(Graph* graph, Schedule* schedule) { append ForTesting to ...
6 years, 1 month ago (2014-11-17 11:35:28 UTC) #2
Benedikt Meurer
LGTM assuming that you add ForTesting soonish ;-)
6 years, 1 month ago (2014-11-17 12:10:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727323002/40001
6 years, 1 month ago (2014-11-17 12:17:25 UTC) #5
dcarney
6 years, 1 month ago (2014-11-17 12:37:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
032191e9be484343d54f50e41b28459634c99aa1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698