Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 7273033: --trace_hydrogen cleanup (Closed)

Created:
9 years, 5 months ago by wingo
Modified:
9 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

--trace_hydrogen cleanup * src/hydrogen.cc (HTracer::Trace): Remove from_bci and to_bci printouts (always -1), xhandlers and flags (always empty), and the bci column for instruction traces (always 0). Also remove <|@ ending, as all instruction traces fit on a line. I googled and it seems the provenance of this goes back at least as far as hotspot! BUG= TEST=

Patch Set 1 #

Patch Set 2 : Also remove vestigial <|@ tail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M src/hydrogen.cc View 1 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wingo
I'm trying to understand some parts of Crankshaft, and I figure that if I decide ...
9 years, 5 months ago (2011-06-28 16:14:31 UTC) #1
Sven Panne
The output of --trace-hydrogen is meant to be read and analyzed by the C1visualizer tool ...
9 years, 5 months ago (2011-06-29 08:32:54 UTC) #2
wingo
9 years, 5 months ago (2011-06-29 08:43:56 UTC) #3
> C1visualizer

Indeed, sorry for the noise; thanks anyway for the review!

Powered by Google App Engine
This is Rietveld 408576698