options: Fix focus "Show advanced settings..." click focus regression.

options: Fix focus "Show advanced settings..." click focus regression.

R=michaelpg@chromium.org
BUG=427387
Committed: https://crrev.com/04438485953c06562e248a3fb9c863c90483159f
Cr-Commit-Position: refs/heads/master@{#304574}

[Dan Beam, 2014-11-18 03:35:38]

alternatively the more invasive and slightly less hacky:
https://codereview.chromium.org/732253002/

https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.js (left):

https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.js:133: if
(document.activeElement === $('advanced-settings-expander') &&
mousedown can call .focus() so this wasn't particularly robust

https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.js:133: if (!e.x &&
showAdvanced) {
it's possible e.x != 0 in the future when pressing Enter
http://www.w3.org/TR/DOM-Level-3-Events/#click-synthesis

[michaelpg, 2014-11-18 03:52:03]

On 2014/11/18 03:35:38, Dan Beam wrote:
> alternatively the more invasive and slightly less hacky:
> https://codereview.chromium.org/732253002/
> 
>
https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
> File chrome/browser/resources/options/browser_options.js (left):
> 
>
https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
> chrome/browser/resources/options/browser_options.js:133: if
> (document.activeElement === $('advanced-settings-expander') &&
> mousedown can call .focus() so this wasn't particularly robust
> 
>
https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
> File chrome/browser/resources/options/browser_options.js (right):
> 
>
https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/opt...
> chrome/browser/resources/options/browser_options.js:133: if (!e.x &&
> showAdvanced) {
> it's possible e.x != 0 in the future when pressing Enter
> http://www.w3.org/TR/DOM-Level-3-Events/#click-synthesis

lbtm ;-)

hopefully this won't be around too-too-much longer, but still, I don't see the
point in adding a "hack" when we already have an object that keeps track of this
for us.

[Dan Beam, 2014-11-18 04:20:49]

changed to use .detail

[michaelpg, 2014-11-18 04:25:11]

lgtm

[Dan Beam, 2014-11-18 06:41:33]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-11-18 06:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727303005/20001

[commit-bot: I haz the power, 2014-11-18 07:21:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-18 07:22:32]

Patchset 2 (id:??) landed as
https://crrev.com/04438485953c06562e248a3fb9c863c90483159f
Cr-Commit-Position: refs/heads/master@{#304574}