Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 727303005: options: Fix focus "Show advanced settings..." click focus regression. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

options: Fix focus "Show advanced settings..." click focus regression. R=michaelpg@chromium.org BUG=427387 Committed: https://crrev.com/04438485953c06562e248a3fb9c863c90483159f Cr-Commit-Position: refs/heads/master@{#304574}

Patch Set 1 #

Total comments: 2

Patch Set 2 : hacky-- #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Dan Beam
alternatively the more invasive and slightly less hacky: https://codereview.chromium.org/732253002/ https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (left): https://codereview.chromium.org/727303005/diff/1/chrome/browser/resources/options/browser_options.js#oldcode133 chrome/browser/resources/options/browser_options.js:133: ...
6 years, 1 month ago (2014-11-18 03:35:38 UTC) #1
michaelpg
On 2014/11/18 03:35:38, Dan Beam wrote: > alternatively the more invasive and slightly less hacky: ...
6 years, 1 month ago (2014-11-18 03:52:03 UTC) #2
Dan Beam
changed to use .detail
6 years, 1 month ago (2014-11-18 04:20:49 UTC) #3
michaelpg
lgtm
6 years, 1 month ago (2014-11-18 04:25:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727303005/20001
6 years, 1 month ago (2014-11-18 06:42:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-18 07:21:50 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 07:22:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04438485953c06562e248a3fb9c863c90483159f
Cr-Commit-Position: refs/heads/master@{#304574}

Powered by Google App Engine
This is Rietveld 408576698