Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 7273005: Added support for two more (bfd) linker flags that will be useful (Closed)

Created:
9 years, 6 months ago by robertm
Modified:
9 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Added support for two more (bfd) linker flags that will be useful to counter the somewhat conservative handling of intrinsics by pnacl. For example: when we see a use of the sin() function we will typically link in a copy of sin() using floating point emulation even if the llc backend can generate a corresponding cpu/copro instructions for sin. This bloats pnacl binaries sowewhat. The -gc-sections instructs the linker to throw out unused functions such as sin(). This only works if they reside in their own section which can be achieved with the -ffunction-section (llvm-)gcc option or via manual annotation. NOTE: this option increases link time somewhat Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5808

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/llvm/driver/pnacl-ld.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robertm
PTAL
9 years, 6 months ago (2011-06-27 17:04:04 UTC) #1
jvoung - send to chromium...
http://codereview.chromium.org/7273005/diff/1/tools/llvm/driver/pnacl-ld.py File tools/llvm/driver/pnacl-ld.py (right): http://codereview.chromium.org/7273005/diff/1/tools/llvm/driver/pnacl-ld.py#newcode154 tools/llvm/driver/pnacl-ld.py:154: ( '(--print-gc-sections)', "env.append('LD_BFD_FLAGS', $0)"), Should be okay to have ...
9 years, 6 months ago (2011-06-27 17:12:54 UTC) #2
robertm
PTAL http://codereview.chromium.org/7273005/diff/1/tools/llvm/driver/pnacl-ld.py File tools/llvm/driver/pnacl-ld.py (right): http://codereview.chromium.org/7273005/diff/1/tools/llvm/driver/pnacl-ld.py#newcode154 tools/llvm/driver/pnacl-ld.py:154: ( '(--print-gc-sections)', "env.append('LD_BFD_FLAGS', $0)"), On 2011/06/27 17:12:54, jvoung ...
9 years, 6 months ago (2011-06-27 17:31:16 UTC) #3
jvoung - send to chromium...
9 years, 6 months ago (2011-06-27 18:17:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698