Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 727283002: Custom Elements in template should not be upgraded (Closed)

Created:
6 years, 1 month ago by deepak.sa
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Custom Elements in template should not be upgraded Custom elements inside the templates were updgraded during cloning of template using importNode. This issue is not with the custom elements but with the import procedure of templates. Use the template document to import the nodes instead of the current document. TEST=fast/dom/HTMLTemplate/import-template.html BUG=430578 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185508

Patch Set 1 #

Total comments: 2

Patch Set 2 : Using ensureTemplateDocument() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
A LayoutTests/fast/dom/HTMLTemplateElement/import-template.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLTemplateElement/import-template-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
deepak.sa
PTAL? Thanks!
6 years, 1 month ago (2014-11-17 07:22:05 UTC) #2
dglazkov
lgtm https://codereview.chromium.org/727283002/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/727283002/diff/1/Source/core/dom/Document.cpp#newcode996 Source/core/dom/Document.cpp:996: && !(toHTMLTemplateElement(oldElement)->content()->document()).importContainerNodeChildren( Could you just use Document::ensureTemplateDocument here, ...
6 years, 1 month ago (2014-11-17 17:26:06 UTC) #4
deepak.sa
https://codereview.chromium.org/727283002/diff/1/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/727283002/diff/1/Source/core/dom/Document.cpp#newcode996 Source/core/dom/Document.cpp:996: && !(toHTMLTemplateElement(oldElement)->content()->document()).importContainerNodeChildren( On 2014/11/17 17:26:06, dglazkov wrote: > Could ...
6 years, 1 month ago (2014-11-18 07:15:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727283002/20001
6 years, 1 month ago (2014-11-18 08:32:47 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 09:21:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185508

Powered by Google App Engine
This is Rietveld 408576698