Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 727253002: Add a test of invalidations with multiple RecalcStyle events (Closed)

Created:
6 years, 1 month ago by pdr.
Modified:
6 years, 1 month ago
Reviewers:
caseq, kouhei (in TOK)
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Add a test of invalidations with multiple RecalcStyle events Multiple RecalcStyle events can occur in a single frame and we didn't have a good test for associating invalidation events in this case. This patch also does some minor cleanup of the style recalc test. BUG=410701 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -21 lines) Patch
M LayoutTests/inspector/tracing/timeline-style-recalc-with-invalidations.html View 3 chunks +87 lines, -21 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-style-recalc-with-invalidations-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pdr.
In a work in progress patch I broke this tricky case. Adding a test so ...
6 years, 1 month ago (2014-11-16 23:46:53 UTC) #2
kouhei (in TOK)
lgtm
6 years, 1 month ago (2014-11-17 05:01:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727253002/1
6 years, 1 month ago (2014-11-17 05:27:04 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 07:31:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185423

Powered by Google App Engine
This is Rietveld 408576698