Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: views/widget/native_widget_unittest.cc

Issue 7272044: Views views_unittests native widget tests leak (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment nit. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/widget/native_widget_test_utils_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/native_widget_unittest.cc
diff --git a/views/widget/native_widget_unittest.cc b/views/widget/native_widget_unittest.cc
index 158f7c6abfd97883192f309a78df5ed20f945ab3..9c7218d6274a7ab994bf5aae96d94ecac7695a25 100644
--- a/views/widget/native_widget_unittest.cc
+++ b/views/widget/native_widget_unittest.cc
@@ -18,16 +18,18 @@ class ScopedTestWidget {
: native_widget_(native_widget) {
}
~ScopedTestWidget() {
+ // |CloseNow| deletes both |native_widget_| and its associated
+ // |Widget|.
native_widget_->GetWidget()->CloseNow();
}
internal::NativeWidgetPrivate* operator->() const {
- return native_widget_.get();
+ return native_widget_;
}
- internal::NativeWidgetPrivate* get() const { return native_widget_.get(); }
+ internal::NativeWidgetPrivate* get() const { return native_widget_; }
private:
- scoped_ptr<internal::NativeWidgetPrivate> native_widget_;
+ internal::NativeWidgetPrivate* native_widget_;
DISALLOW_COPY_AND_ASSIGN(ScopedTestWidget);
};
@@ -62,11 +64,15 @@ TEST_F(NativeWidgetTest, GetTopLevelNativeWidget1) {
// |toplevel_widget| has the toplevel NativeWidget.
TEST_F(NativeWidgetTest, GetTopLevelNativeWidget2) {
- ScopedTestWidget child_widget(internal::CreateNativeWidgetWithParent(NULL));
ScopedTestWidget toplevel_widget(internal::CreateNativeWidget());
+ // |toplevel_widget| owns |child_host|.
NativeViewHost* child_host = new NativeViewHost;
toplevel_widget->GetWidget()->SetContentsView(child_host);
+
+ // |child_host| owns |child_widget|.
+ internal::NativeWidgetPrivate* child_widget =
+ internal::CreateNativeSubWidget();
child_host->Attach(child_widget->GetWidget()->GetNativeView());
EXPECT_EQ(toplevel_widget.get(),
« no previous file with comments | « views/widget/native_widget_test_utils_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698