views/widget/native_widget_test_utils.h - Issue 7272044: Views views_unittests native widget tests leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/widget/native_widget_test_utils.h

Issue 7272044: Views views_unittests native widget tests leak (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment nit. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/widget/native_widget_test_utils.h

diff --git a/views/widget/native_widget_test_utils.h b/views/widget/native_widget_test_utils.h

index 2499a7654d60c664533050451866cc09c2e75a06..cd51d384bc1cc82235329e9949b969412f21fa65 100644

--- a/views/widget/native_widget_test_utils.h

+++ b/views/widget/native_widget_test_utils.h

@@ -11,10 +11,10 @@ class View;

namespace internal {

class NativeWidgetPrivate;

-// Create dummy Widgets for use in testing.

+// Create dummy widgets for use in testing. Caller owns the returned

+// |NativeWidgetPrivate| object which, in turn, owns the associated Widget.

NativeWidgetPrivate* CreateNativeWidget();

-NativeWidgetPrivate* CreateNativeWidgetWithContents(View* contents_view);

-NativeWidgetPrivate* CreateNativeWidgetWithParent(NativeWidgetPrivate* parent);

+NativeWidgetPrivate* CreateNativeSubWidget();

} // namespace internal

} // namespace views

« no previous file with comments | « tools/valgrind/chrome_tests.py ('k') | views/widget/native_widget_test_utils_gtk.cc » ('j') | no next file with comments »