Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: views/widget/native_widget_test_utils_gtk.cc

Issue 7272044: Views views_unittests native widget tests leak (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment nit. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « views/widget/native_widget_test_utils.h ('k') | views/widget/native_widget_test_utils_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/widget/native_widget_test_utils.h" 5 #include "views/widget/native_widget_test_utils.h"
6 6
7 #include "views/view.h" 7 #include "views/view.h"
8 #include "views/widget/native_widget_private.h" 8 #include "views/widget/native_widget_private.h"
9 #include "views/widget/widget.h" 9 #include "views/widget/widget.h"
10 10
11 namespace views { 11 namespace views {
12 namespace internal { 12 namespace internal {
13 13
14 NativeWidgetPrivate* CreateNativeWidget() { 14 namespace {
15 return CreateNativeWidgetWithContents(new View);
16 }
17 15
18 NativeWidgetPrivate* CreateNativeWidgetWithContents(View* contents_view) { 16 NativeWidgetPrivate* CreateNativeWidgetOfType(Widget::InitParams::Type type) {
19 Widget* widget = new Widget; 17 Widget* widget = new Widget;
20 Widget::InitParams params(Widget::InitParams::TYPE_POPUP); 18 Widget::InitParams params(type);
21 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 19 params.ownership = views::Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET;
22 params.bounds = gfx::Rect(10, 10, 200, 200); 20 params.bounds = gfx::Rect(10, 10, 200, 200);
23 widget->Init(params); 21 widget->Init(params);
24 return widget->native_widget_private(); 22 return widget->native_widget_private();
25 } 23 }
26 24
27 NativeWidgetPrivate* CreateNativeWidgetWithParent(NativeWidgetPrivate* parent) { 25 } // namespace
28 Widget* widget = new Widget; 26
29 Widget::InitParams params(Widget::InitParams::TYPE_CONTROL); 27 NativeWidgetPrivate* CreateNativeWidget() {
30 params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET; 28 return CreateNativeWidgetOfType(Widget::InitParams::TYPE_POPUP);
31 params.parent = parent ? parent->GetWidget()->GetNativeView() : NULL; 29 }
32 params.bounds = gfx::Rect(10, 10, 200, 200); 30
33 widget->Init(params); 31 NativeWidgetPrivate* CreateNativeSubWidget() {
34 return widget->native_widget_private(); 32 return CreateNativeWidgetOfType(Widget::InitParams::TYPE_CONTROL);
35 } 33 }
36 34
37 } // namespace internal 35 } // namespace internal
38 } // namespace ui 36 } // namespace ui
OLDNEW
« no previous file with comments | « views/widget/native_widget_test_utils.h ('k') | views/widget/native_widget_test_utils_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698