Plugin Power Saver: Force SW rendering for peripheral plugins.

Plugin Power Saver: Force SW rendering for peripheral plugins.

Keyframes cannot be efficiently extracted when plugins use the hardware
backend for rendering. This change forces plugins determined to be
peripheral to use the software backend for rendering.

BUG=403800
Committed: https://crrev.com/8e6e33fbfe2856ed8c33384c83be652ee933d965
Cr-Commit-Position: refs/heads/master@{#304646}

[tommycli, 2014-11-14 22:33:45]

tommycli@chromium.org changed reviewers:
+ groby@chromium.org, piman@chromium.org

[tommycli, 2014-11-14 22:34:54]

groby/piman: For your reviewing pleasure.

[groby-ooo-7-16, 2014-11-14 22:45:39]

https://codereview.chromium.org/727073002/diff/1/content/renderer/pepper/reso...
File content/renderer/pepper/resource_creation_impl.cc (right):

https://codereview.chromium.org/727073002/diff/1/content/renderer/pepper/reso...
content/renderer/pepper/resource_creation_impl.cc:112: // Force SW rendering for
keyframe extraction to avoid pixel reads from VRAM.
I'm curious: ResourceCreationImpl has essentially no logic whatsoever - should
this live on PPB_Graphics3D_Impl::Create ?

[piman, 2014-11-14 22:53:01]

https://codereview.chromium.org/727073002/diff/1/content/renderer/pepper/reso...
File content/renderer/pepper/resource_creation_impl.cc (right):

https://codereview.chromium.org/727073002/diff/1/content/renderer/pepper/reso...
content/renderer/pepper/resource_creation_impl.cc:112: // Force SW rendering for
keyframe extraction to avoid pixel reads from VRAM.
On 2014/11/14 22:45:39, groby wrote:
> I'm curious: ResourceCreationImpl has essentially no logic whatsoever - should
> this live on PPB_Graphics3D_Impl::Create ?

Yes, this logic should go to PPB_Graphics3D_Impl::InitRaw (so that it applies to
both in-process and out-of-process pepper). Note some existing logic there wrt
blacklisting.

[tommycli, 2014-11-14 23:58:22]

thanks! i tested this. it works on my machine.

https://codereview.chromium.org/727073002/diff/1/content/renderer/pepper/reso...
File content/renderer/pepper/resource_creation_impl.cc (right):

https://codereview.chromium.org/727073002/diff/1/content/renderer/pepper/reso...
content/renderer/pepper/resource_creation_impl.cc:112: // Force SW rendering for
keyframe extraction to avoid pixel reads from VRAM.
On 2014/11/14 22:45:39, groby wrote:
> I'm curious: ResourceCreationImpl has essentially no logic whatsoever - should
> this live on PPB_Graphics3D_Impl::Create ?

Done.

https://codereview.chromium.org/727073002/diff/1/content/renderer/pepper/reso...
content/renderer/pepper/resource_creation_impl.cc:112: // Force SW rendering for
keyframe extraction to avoid pixel reads from VRAM.
On 2014/11/14 22:53:00, piman (Very slow to review) wrote:
> On 2014/11/14 22:45:39, groby wrote:
> > I'm curious: ResourceCreationImpl has essentially no logic whatsoever -
should
> > this live on PPB_Graphics3D_Impl::Create ?
> 
> Yes, this logic should go to PPB_Graphics3D_Impl::InitRaw (so that it applies
to
> both in-process and out-of-process pepper). Note some existing logic there wrt
> blacklisting.

Done.

[piman, 2014-11-15 00:46:58]

lgtm

[tommycli, 2014-11-18 18:18:35]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-11-18 18:19:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/727073002/40001

[commit-bot: I haz the power, 2014-11-18 18:59:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-18 19:00:48]

Patchset 3 (id:??) landed as
https://crrev.com/8e6e33fbfe2856ed8c33384c83be652ee933d965
Cr-Commit-Position: refs/heads/master@{#304646}