Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 727053002: Add DropPrivileges() (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add DropPrivileges(). DropPrivileges() is used in exception_port_tool, so that when it is installed as a setuid executable, it only uses elevated privileges to obtain a task port for its -p option, and then relinquishes those privileges. It is difficult to provide a test for this function, because it must be running setuid or setgid in order to do anything interesting. However, the function contains its own CHECKs to verify that it behaves properly. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/49d7fdba9af9d465dc4eda940585523d810008e3

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M tools/exception_port_tool.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
A util/posix/drop_privileges.h View 1 chunk +40 lines, -0 lines 0 comments Download
A util/posix/drop_privileges.cc View 1 chunk +73 lines, -0 lines 1 comment Download
M util/util.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-11-14 21:52:12 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/727053002/diff/20001/util/posix/drop_privileges.cc File util/posix/drop_privileges.cc (right): https://codereview.chromium.org/727053002/diff/20001/util/posix/drop_privileges.cc#newcode65 util/posix/drop_privileges.cc:65: // CAP_SETUID and CAP_SETGID capabilities, which may be ...
6 years, 1 month ago (2014-11-14 23:36:03 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-11-14 23:44:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
49d7fdba9af9d465dc4eda940585523d810008e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698