components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc - Issue 726923004: Cleanup: Use http/https constants in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

Issue 726923004: Cleanup: Use http/https constants in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

index 17b3f803837bc9e666725c940dcc76dcf90b4730..3f7bb107c3713685a2eea6fd29c84a1297bd2ec6 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc

@@ -29,7 +29,7 @@ bool SetProxyServerFromGURL(const GURL& gurl,

DCHECK(proxy_server);

if (!gurl.SchemeIsHTTPOrHTTPS())

return false;

- *proxy_server = net::ProxyServer(gurl.SchemeIs("http") ?

+ *proxy_server = net::ProxyServer(gurl.SchemeIs(url::kHttpScheme) ?

net::ProxyServer::SCHEME_HTTP :

net::ProxyServer::SCHEME_HTTPS,

net::HostPortPair::FromURL(gurl));

@@ -170,7 +170,7 @@ bool IsRequestIdempotent(const net::URLRequest* request) {

void MarkProxiesAsBadUntil(

net::URLRequest* request,

- base::TimeDelta& bypass_duration,

+ const base::TimeDelta& bypass_duration,

bool bypass_all,

const std::pair<GURL, GURL>& data_reduction_proxies) {

DCHECK(!data_reduction_proxies.first.is_empty());