components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc - Issue 726923004: Cleanup: Use http/https constants in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

Issue 726923004: Cleanup: Use http/https constants in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

index ca741f8f3e5897680e29ec0decd4b2af100a0108..af0932b0c25b00dcccf86e472c074386b5a0bbe8 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc

@@ -17,6 +17,7 @@

#include "net/proxy/proxy_retry_info.h"

#include "net/proxy/proxy_service.h"

#include "net/url_request/url_request_context.h"

+#include "url/url_constants.h"

namespace data_reduction_proxy {

@@ -292,9 +293,9 @@ class DailyDataSavingUpdate {

DataReductionProxyRequestType GetDataReductionProxyRequestType(

const net::URLRequest* request) {

- if (request->url().SchemeIs("https"))

+ if (request->url().SchemeIs(url::kHttpsScheme))

return HTTPS;

- if (!request->url().SchemeIs("http")) {

+ if (!request->url().SchemeIs(url::kHttpScheme)) {

NOTREACHED();

return UNKNOWN_TYPE;

}