Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 726923004: Cleanup: Use http/https constants in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 8ce3a2948dfe570068b273210dd3e88583c3f34e..63093c974a547ce2c001505a0fc7df6c136dca88 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -117,9 +117,7 @@ bool SectionIsAutofilled(const FormStructure& form_structure,
}
bool FormIsHTTPS(const FormStructure& form) {
- // TODO(blundell): Change this to use a constant once crbug.com/306258 is
- // fixed.
- return form.source_url().SchemeIs("https");
+ return form.source_url().SchemeIs(url::kHttpsScheme);
}
// Uses the existing personal data in |profiles| and |credit_cards| to determine
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698