Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 726853003: Adding Accelerator key for 'Reload' and 'View Source'. (Closed)

Created:
6 years, 1 month ago by Deepak
Modified:
6 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding Accelerator key for 'Reload' and 'View Source'. In the context menu Accelerator key for 'Reload' and 'View Source' is not shown. It should be shown so that user will lean and can do operations without opening context menu. BUG=434334 Committed: https://crrev.com/1390e4c03f1787a482d63730c7ef03913f350afb Cr-Commit-Position: refs/heads/master@{#304740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
Followup for Accelerator key's PTAL
6 years, 1 month ago (2014-11-18 13:38:45 UTC) #2
msw
lgtm
6 years, 1 month ago (2014-11-18 19:09:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726853003/1
6 years, 1 month ago (2014-11-19 01:09:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 01:59:03 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 01:59:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1390e4c03f1787a482d63730c7ef03913f350afb
Cr-Commit-Position: refs/heads/master@{#304740}

Powered by Google App Engine
This is Rietveld 408576698