Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 72683003: Auto-generate InputTypeNames source from InputTypeNames.in. (Closed)

Created:
7 years, 1 month ago by tkent
Modified:
7 years, 1 month ago
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering
Visibility:
Public.

Description

Auto-generate InputTypeNames source from InputTypeNames.in. make_names.py generates InputTypeNames.{cpp,h} from InputTypeNames.in. This change makes InputTypeNames thread-safe. So reverts HTMLPreloadScanner.cpp change in r161989 [1]. - InputTypeNames functions become global variables. We omit "()". - Rename InputTypeNames::telephone to tel, and InputTypeNames::datetimelocal to datetime_local. - Fix a make_names.py problem that it generates C++ symbol name "datetime-local". [1] http://src.chromium.org/viewvc/blink?revision=161989&view=revision BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162037

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -367 lines) Patch
M Source/build/scripts/make_names.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/Init.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/core_derived_sources.gyp View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/core/html/forms/ButtonInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/CheckboxInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/DateInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/EmailInputType.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/HiddenInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 5 chunks +25 lines, -25 lines 1 comment Download
D Source/core/html/forms/InputTypeNames.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/html/forms/InputTypeNames.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
A Source/core/html/forms/InputTypeNames.in View 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/html/forms/MonthInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/NumberInputType.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/PasswordInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/RadioInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/ResetInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/SubmitInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/TelephoneInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/TextInputType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/TimeInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/URLInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/WeekInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 3 chunks +16 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/web/ExternalDateTimeChooser.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
abarth, would you review this please?
7 years, 1 month ago (2013-11-14 14:56:09 UTC) #1
eseidel
lgtm Looks great. https://codereview.chromium.org/72683003/diff/70001/Source/core/html/forms/InputType.cpp File Source/core/html/forms/InputType.cpp (right): https://codereview.chromium.org/72683003/diff/70001/Source/core/html/forms/InputType.cpp#newcode86 Source/core/html/forms/InputType.cpp:86: map->add(InputTypeNames::date, DateInputType::create); This looks very much ...
7 years, 1 month ago (2013-11-14 15:17:18 UTC) #2
abarth-chromium
Thanks!!
7 years, 1 month ago (2013-11-14 16:24:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/72683003/70001
7 years, 1 month ago (2013-11-14 16:25:06 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 18:23:31 UTC) #5
Message was sent while issue was closed.
Change committed as 162037

Powered by Google App Engine
This is Rietveld 408576698