Source/bindings/scripts/v8_union.py - Issue 726793002: IDL: Update type error message for invalid union values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_union.py

Issue 726793002: IDL: Update type error message for invalid union values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_union.py

diff --git a/Source/bindings/scripts/v8_union.py b/Source/bindings/scripts/v8_union.py

index 45277fa0c133f394a0cf597bc3f65a78c89f7087..d4168ffe3c211cf67042db9307e5e2ac2adce40a 100644

--- a/Source/bindings/scripts/v8_union.py

+++ b/Source/bindings/scripts/v8_union.py

@@ -109,6 +109,7 @@ def container_context(union_type, interfaces_info):

'boolean_type': boolean_type,

'cpp_class': union_type.cpp_type,

'dictionary_type': dictionary_type,

+ 'idl_type': str(union_type),

haraken 2014/11/14 00:44:30 idl_type => type_string ? (The IDL compiler uses

bashi 2014/11/14 00:51:38 Done. (I used "idl_type" because v8_attribute.py u

'includes_nullable_type': union_type.includes_nullable_type,

'interface_types': interface_types,

'members': members,

« no previous file with comments | « LayoutTests/fast/js/select-options-add-expected.txt ('k') | Source/bindings/templates/union.cpp » ('j') | no next file with comments »