src/objects.h - Issue 726773002: Throw as per spec when modifying an Array with builtin methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 726773002: Throw as per spec when modifying an Array with builtin methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index 77dcb8cc818b985a43bb98fc8cea61392f93d6a9..1df111171956caed3d3b59e901ddd3c36846b909 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -10185,6 +10185,7 @@ class JSArray: public JSObject {

Handle<Object> value);

static bool IsReadOnlyLengthDescriptor(Handle<Map> jsarray_map);

+ static bool HasReadOnlyLength(Handle<JSArray> array);

static bool WouldChangeReadOnlyLength(Handle<JSArray> array, uint32_t index);

static MaybeHandle<Object> ReadOnlyLengthError(Handle<JSArray> array);

« no previous file with comments | « src/builtins.cc ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')