Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 726743002: Fix external_application_unittests and add to mojob.py (Closed)

Created:
6 years, 1 month ago by Chris Masone
Modified:
6 years, 1 month ago
Reviewers:
jam, DaveMoore, jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix external_application_unittests and add to mojob.py These rusted a bit because they were not being run by mojob.py. Fix them, and add them to the list of unittests. BUG=None TEST=mojob.py R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e956d11e7e5878c0044ec6256565afd487662c59

Patch Set 1 #

Patch Set 2 : allow my unittests to compile into an empty test suite on Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -14 lines) Patch
M mojo/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 3 chunks +22 lines, -4 lines 0 comments Download
M mojo/shell/external_application_listener_unittest.cc View 4 chunks +26 lines, -8 lines 0 comments Download
M mojo/shell/external_application_test_main.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/tools/data/unittests View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Chris Masone
+davemoore for code changes, +jam for mojob changes. Jam, is it a problem that these ...
6 years, 1 month ago (2014-11-13 23:22:59 UTC) #2
jam
On 2014/11/13 23:22:59, Chris Masone wrote: > +davemoore for code changes, > +jam for mojob ...
6 years, 1 month ago (2014-11-14 16:32:51 UTC) #3
Chris Masone
As far as I can tell, this should allow my unittest binary to trivially pass ...
6 years, 1 month ago (2014-11-14 23:14:03 UTC) #4
DaveMoore
lgtm
6 years, 1 month ago (2014-11-17 16:13:52 UTC) #5
Chris Masone
Committed patchset #2 (id:20001) manually as e956d11e7e5878c0044ec6256565afd487662c59 (presubmit successful).
6 years, 1 month ago (2014-11-17 17:05:18 UTC) #6
jamesr
This made the windows build red in the test step: http://build.chromium.org/p/client.mojo/builders/Mojo%20Win%20%28dbg%29/builds/138/steps/mojob%20test/logs/stdio Running unit tests in ...
6 years, 1 month ago (2014-11-17 21:06:14 UTC) #8
Chris Masone
On 2014/11/17 21:06:14, jamesr wrote: > This made the windows build red in the test ...
6 years, 1 month ago (2014-11-17 21:16:05 UTC) #9
jamesr
6 years, 1 month ago (2014-11-17 22:34:59 UTC) #10
Message was sent while issue was closed.
It didn't used to be supported, but now it's on the waterfall.

Powered by Google App Engine
This is Rietveld 408576698