Fix external_application_unittests and add to mojob.py

Fix external_application_unittests and add to mojob.py

These rusted a bit because they were not being run by
mojob.py. Fix them, and add them to the list of unittests.

BUG=None
TEST=mojob.py
R=davemoore@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/e956d11e7e5878c0044ec6256565afd487662c59

[Chris Masone, 2014-11-13 23:22:18]

cmasone@chromium.org changed reviewers:
+ davemoore@chromium.org, jam@chromium.org

[Chris Masone, 2014-11-13 23:22:59]

+davemoore for code changes,
+jam for mojob changes. Jam, is it a problem that these tests are not built on
windows, or will the tool just skip them?

[jam, 2014-11-14 16:32:51]

On 2014/11/13 23:22:59, Chris Masone wrote:
> +davemoore for code changes,
> +jam for mojob changes. Jam, is it a problem that these tests are not built on
> windows, or will the tool just skip them?

i'm not familiar with the test runner script. does it look like it will skip
binaries that aren't there? (haven't looked)

[Chris Masone, 2014-11-14 23:14:03]

As far as I can tell, this should allow my unittest binary to trivially pass on
Windows, so we can add it to mojob.py

Dave, can you look at the C++ changes?

[DaveMoore, 2014-11-17 16:13:52]

lgtm

[Chris Masone, 2014-11-17 17:05:18]

Committed patchset #2 (id:20001) manually as
e956d11e7e5878c0044ec6256565afd487662c59 (presubmit successful).

[jamesr, 2014-11-17 21:06:13]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-11-17 21:06:14]

This made the windows build red in the test step:

http://build.chromium.org/p/client.mojo/builders/Mojo%20Win%20%28dbg%29/build...

Running unit tests in out\Debug ...
Running tests in directory: out\Debug
Successes cache file: mojob_test_successes
Failed to read successes cache file mojob_test_successes (will create)
Running mojo_system_unittests.exe.... Succeeded
Running mojo_public_bindings_unittests.exe.... Succeeded
Running mojo_public_environment_unittests.exe.... Succeeded
Running mojo_public_system_unittests.exe.... Succeeded
Running mojo_public_utility_unittests.exe.... Succeeded
Running clipboard_unittests.exe.... Succeeded
Running mojo_application_manager_unittests.exe.... Succeeded
Running mojo_common_unittests.exe.... Succeeded

@@@STEP_CURSOR mojob test@@@

@@@STEP_FAILURE@@@

@@@STEP_CURSOR mojob test@@@

[Chris Masone, 2014-11-17 21:16:05]

On 2014/11/17 21:06:14, jamesr wrote:
> This made the windows build red in the test step:
> 
>
http://build.chromium.org/p/client.mojo/builders/Mojo%20Win%20%28dbg%29/build...
> 
> Running unit tests in out\Debug ...
> Running tests in directory: out\Debug
> Successes cache file: mojob_test_successes
> Failed to read successes cache file mojob_test_successes (will create)
> Running mojo_system_unittests.exe.... Succeeded
> Running mojo_public_bindings_unittests.exe.... Succeeded
> Running mojo_public_environment_unittests.exe.... Succeeded
> Running mojo_public_system_unittests.exe.... Succeeded
> Running mojo_public_utility_unittests.exe.... Succeeded
> Running clipboard_unittests.exe.... Succeeded
> Running mojo_application_manager_unittests.exe.... Succeeded
> Running mojo_common_unittests.exe.... Succeeded
> 
> @@@STEP_CURSOR mojob test@@@
> 
> @@@STEP_FAILURE@@@
> 
> @@@STEP_CURSOR mojob test@@@

That log fragment has no errors that I can see, but when jam pointed that out to
me, it looked from the overall build stdio like the issue was that I didn't have
the (trivial) external_application_unittests binary building on Windows, which
is why I landed https://codereview.chromium.org/736443002/
but I have no Windows machine and no trybots, so it's not clear to me how I'm
supposed to fix this. Is Windows a supported target? I thought it was explicitly
out of scope.

[jamesr, 2014-11-17 22:34:59]

It didn't used to be supported, but now it's on the waterfall.