Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: src/heap/objects-visiting.h

Issue 726713003: LayoutDescriptorHelper is now able to calculate the length of contiguous regions of tagged/non-tagg… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_VISITING_H_ 5 #ifndef V8_OBJECTS_VISITING_H_
6 #define V8_OBJECTS_VISITING_H_ 6 #define V8_OBJECTS_VISITING_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/layout-descriptor.h" 9 #include "src/layout-descriptor.h"
10 10
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 HeapObject::RawField(object, end_offset)); 219 HeapObject::RawField(object, end_offset));
220 } 220 }
221 221
222 static void IterateBodyUsingLayoutDescriptor(Heap* heap, HeapObject* object, 222 static void IterateBodyUsingLayoutDescriptor(Heap* heap, HeapObject* object,
223 int start_offset, 223 int start_offset,
224 int end_offset) { 224 int end_offset) {
225 DCHECK(FLAG_unbox_double_fields); 225 DCHECK(FLAG_unbox_double_fields);
226 DCHECK(IsAligned(start_offset, kPointerSize) && 226 DCHECK(IsAligned(start_offset, kPointerSize) &&
227 IsAligned(end_offset, kPointerSize)); 227 IsAligned(end_offset, kPointerSize));
228 228
229 InobjectPropertiesHelper helper(object->map()); 229 LayoutDescriptorHelper helper(object->map());
230 DCHECK(!helper.all_fields_tagged()); 230 DCHECK(!helper.all_fields_tagged());
231 231 for (int offset = start_offset; offset < end_offset;) {
232 for (int offset = start_offset; offset < end_offset; 232 int end_of_region_offset;
233 offset += kPointerSize) { 233 if (helper.IsTagged(offset, end_offset, &end_of_region_offset)) {
234 // Visit tagged fields only. 234 IterateRawPointers(heap, object, offset, end_of_region_offset);
235 if (helper.IsTagged(offset)) {
236 // TODO(ishell): call this once for contiguous region of tagged fields.
237 IterateRawPointers(heap, object, offset, offset + kPointerSize);
238 } 235 }
236 offset = end_of_region_offset;
239 } 237 }
240 } 238 }
241 }; 239 };
242 240
243 241
244 template <typename StaticVisitor, typename BodyDescriptor, typename ReturnType> 242 template <typename StaticVisitor, typename BodyDescriptor, typename ReturnType>
245 class FlexibleBodyVisitor : public BodyVisitorBase<StaticVisitor> { 243 class FlexibleBodyVisitor : public BodyVisitorBase<StaticVisitor> {
246 public: 244 public:
247 INLINE(static ReturnType Visit(Map* map, HeapObject* object)) { 245 INLINE(static ReturnType Visit(Map* map, HeapObject* object)) {
248 int object_size = BodyDescriptor::SizeOf(map, object); 246 int object_size = BodyDescriptor::SizeOf(map, object);
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 // the next element. Given the head of the list, this function removes dead 486 // the next element. Given the head of the list, this function removes dead
489 // elements from the list and if requested records slots for next-element 487 // elements from the list and if requested records slots for next-element
490 // pointers. The template parameter T is a WeakListVisitor that defines how to 488 // pointers. The template parameter T is a WeakListVisitor that defines how to
491 // access the next-element pointers. 489 // access the next-element pointers.
492 template <class T> 490 template <class T>
493 Object* VisitWeakList(Heap* heap, Object* list, WeakObjectRetainer* retainer); 491 Object* VisitWeakList(Heap* heap, Object* list, WeakObjectRetainer* retainer);
494 } 492 }
495 } // namespace v8::internal 493 } // namespace v8::internal
496 494
497 #endif // V8_OBJECTS_VISITING_H_ 495 #endif // V8_OBJECTS_VISITING_H_
OLDNEW
« no previous file with comments | « src/heap/mark-compact.cc ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698