Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 726693004: Re-land r25392 Use a stub in crankshaft for grow store arrays. (Closed)

Created:
6 years, 1 month ago by mvstanton
Modified:
6 years, 1 month ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Re-land r25392 Use a stub in crankshaft for grow store arrays. Code was vulnerable to different evaluation order in Clang. R=danno@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/47f55baeaff0d59366772db95b6c0328a216f611

Patch Set 1 : Base. #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -29 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +24 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 chunks +34 lines, -10 lines 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +4 lines, -1 line 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +13 lines, -1 line 0 comments Download
M src/interface-descriptors.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +10 lines, -5 lines 0 comments Download
M src/objects.cc View 5 chunks +24 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/ensure-growing-store-learns.js View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mvstanton
Hi Danno, Here is the reland with the Clang fix. PTAL, thanks, --Michael
6 years, 1 month ago (2014-11-18 14:17:33 UTC) #2
danno
lgtm
6 years, 1 month ago (2014-11-18 14:18:41 UTC) #3
mvstanton
6 years, 1 month ago (2014-11-18 14:31:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
47f55baeaff0d59366772db95b6c0328a216f611 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698