Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 726693002: Use DrawStates ProcOptInfo when creating the Optimized Draw State. (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Use DrawStates ProcOptInfo when creating the Optimized Draw State. BUG=skia: Committed: https://skia.googlesource.com/skia/+/912b3d24a0e214e46a211da40cc01fe30238386c

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Move to pri pri pri private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -64 lines) Patch
M src/gpu/GrDrawState.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 3 chunks +13 lines, -64 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
egdaniel
6 years, 1 month ago (2014-11-13 21:17:51 UTC) #2
bsalomon
https://codereview.chromium.org/726693002/diff/20001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/726693002/diff/20001/src/gpu/GrDrawState.h#newcode452 src/gpu/GrDrawState.h:452: const GrProcOptInfo& colorProcInfo() const { puhpuhpuhpublic? Can this somehow ...
6 years, 1 month ago (2014-11-13 22:04:57 UTC) #3
egdaniel
https://codereview.chromium.org/726693002/diff/20001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/726693002/diff/20001/src/gpu/GrDrawState.h#newcode452 src/gpu/GrDrawState.h:452: const GrProcOptInfo& colorProcInfo() const { On 2014/11/13 22:04:57, bsalomon ...
6 years, 1 month ago (2014-11-14 15:36:30 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-11-14 19:34:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726693002/40001
6 years, 1 month ago (2014-11-17 14:19:32 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 15:46:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/912b3d24a0e214e46a211da40cc01fe30238386c

Powered by Google App Engine
This is Rietveld 408576698