Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: net/socket/tcp_socket_libevent.cc

Issue 726673002: Add a new NetworkActivityMonitor to track network activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: NET_EXPORT_PRIVATE Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/tcp_socket_libevent.cc
diff --git a/net/socket/tcp_socket_libevent.cc b/net/socket/tcp_socket_libevent.cc
index cc2376590f57de1904e8d2edef9e765ce740dc71..c6012dfa67e9e4d7109594bdbc29dfaff3b45358 100644
--- a/net/socket/tcp_socket_libevent.cc
+++ b/net/socket/tcp_socket_libevent.cc
@@ -21,6 +21,7 @@
#include "net/base/ip_endpoint.h"
#include "net/base/net_errors.h"
#include "net/base/net_util.h"
+#include "net/base/network_activity_monitor.h"
#include "net/base/network_change_notifier.h"
#include "net/socket/socket_libevent.h"
#include "net/socket/socket_net_log_params.h"
@@ -601,6 +602,8 @@ int TCPSocketLibevent::HandleReadCompleted(IOBuffer* buf, int rv) {
read_bytes.Add(rv);
net_log_.AddByteTransferEvent(NetLog::TYPE_SOCKET_BYTES_RECEIVED, rv,
buf->data());
+ NetworkActivityMonitor::GetInstance()->AddBytesRead(rv);
eroman 2014/11/13 22:18:39 Perhaps calling this AddBytesReceived() would be m
Ryan Hamilton 2014/11/13 23:38:18 Done. Would you also recommend s/Written/Sent/?
eroman 2014/11/14 00:06:15 sgtm
+
return rv;
}
@@ -633,6 +636,7 @@ int TCPSocketLibevent::HandleWriteCompleted(IOBuffer* buf, int rv) {
write_bytes.Add(rv);
net_log_.AddByteTransferEvent(NetLog::TYPE_SOCKET_BYTES_SENT, rv,
buf->data());
+ NetworkActivityMonitor::GetInstance()->AddBytesWritten(rv);
return rv;
}

Powered by Google App Engine
This is Rietveld 408576698