Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 726653003: DevTools: add Paint Profiler link to layer & event details views (Closed)

Created:
6 years, 1 month ago by caseq
Modified:
6 years, 1 month ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: add Paint Profiler link to layer & event details views - add a "Paint Profiler" link to layer details view when paint is selected; - add a "Paint Profiler" link to Paint event details view; - collapse Size & Position cells of Layer Details View into Size: W x H (at X,Y) - do not show Paint Count if it's 0 (Paint Count is n/a in Timeline) - do not force-switch to Paint Profiler tab in Timeline details if user explicitly selected other tab. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -25 lines) Patch
M Source/devtools/front_end/timeline/LayerDetailsView.js View 6 chunks +31 lines, -19 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineLayersView.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 5 chunks +6 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +9 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
caseq
Layer Details View screenshot: https://drive.google.com/file/d/0B_yi9xtujhXSNGQ0aW1IaURzM0k/view?usp=sharing
6 years, 1 month ago (2014-11-14 10:12:34 UTC) #2
pfeldman
lgtm
6 years, 1 month ago (2014-11-17 14:11:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726653003/1
6 years, 1 month ago (2014-11-17 14:26:42 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 16:23:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185452

Powered by Google App Engine
This is Rietveld 408576698