Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 72663006: Remove unit_tests target from iOS builds. (Closed)

Created:
7 years, 1 month ago by justincohen
Modified:
7 years, 1 month ago
Reviewers:
stuartmorgan, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Remove unit_tests target from iOS builds. chrome/ is no longer being brought up on iOS, since code used on iOS should be extracted into layered components. unit_tests is now empty on iOS, so stop building it. BUG=312293 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/all.gyp View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
justincohen
stuartmorgan for review, thakis for OWNERS. PTAL!
7 years, 1 month ago (2013-11-19 19:22:05 UTC) #1
stuartmorgan
lgtm
7 years, 1 month ago (2013-11-19 19:35:05 UTC) #2
Nico
lgtm BUG=312293?
7 years, 1 month ago (2013-11-20 01:45:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justincohen@chromium.org/72663006/1
7 years, 1 month ago (2013-11-20 02:05:53 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 05:34:43 UTC) #5
Message was sent while issue was closed.
Change committed as 236164

Powered by Google App Engine
This is Rietveld 408576698