Revert of [Android] Experimental sync barrier detection for tracing

Revert of [Android] Experimental sync barrier detection for tracing (patchset #6 id:100001 of https://codereview.chromium.org/575103002/)

Reason for revert:
Barrier detection is no longer necessary, see crrev.com/512333002.

Original issue's description:
> [Android] Experimental sync barrier detection for tracing
>
> When an Android View is invalidated outside of frame dispatch
> (animation/input/draw), a sync barrier may be inserted into the shared
> UI thread message loop. This effectively blocks dispatch of all Chrome
> tasks posted to the browser UI thread for an entire frame (or more if
> the View is continually invalidated).
>
> There are currently no easy or even automated ways to avoid this
> untimely invalidation, and judicious coding can only take us so far. As
> an intermediate assist in debugging the issue, use reflection and a
> crude form of MessageQueue inspection to trace known cases where the
> MessageQueue is blocked by a sync barrier.
>
> Note that this detection is not perfect, neither is it exact, but it's a
> solid proxy for informing traces about such pipeline stalls.
>
> BUG=407133
>
> Committed: https://crrev.com/85bceaa6e05ee1bf42ac220ddcbb50ca268c1ea4
> Cr-Commit-Position: refs/heads/master@{#296249}

TBR=epenner@chromium.org,epenner@google.com,nyquist@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407133
Committed: https://crrev.com/adefc40cb9652a2ea046bbdbef223d881f4a7463
Cr-Commit-Position: refs/heads/master@{#304040}

[jdduke (slow), 2014-11-13 16:54:09]

Created Revert of [Android] Experimental sync barrier detection for tracing

[jdduke (slow), 2014-11-13 16:54:33]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-11-13 16:55:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/726623002/1

[commit-bot: I haz the power, 2014-11-13 16:55:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-13 16:55:42]

Failed to apply patch for
base/android/java/src/org/chromium/base/SystemMessageHandler.java:
While running git apply --index -3 -p1;
  error: patch failed:
base/android/java/src/org/chromium/base/SystemMessageHandler.java:25
  Falling back to three-way merge...
  Applied patch to
'base/android/java/src/org/chromium/base/SystemMessageHandler.java' with
conflicts.
  U base/android/java/src/org/chromium/base/SystemMessageHandler.java

Patch:       base/android/java/src/org/chromium/base/SystemMessageHandler.java
Index: base/android/java/src/org/chromium/base/SystemMessageHandler.java
diff --git a/base/android/java/src/org/chromium/base/SystemMessageHandler.java
b/base/android/java/src/org/chromium/base/SystemMessageHandler.java
index
a3c81ae1046d50aa368a613ee63320700227c84e..e1fbb0f4bed9538212313fdb374e81f0ac37f414
100644
--- a/base/android/java/src/org/chromium/base/SystemMessageHandler.java
+++ b/base/android/java/src/org/chromium/base/SystemMessageHandler.java
@@ -5,18 +5,9 @@
 package org.chromium.base;
 
 import android.os.Handler;
-import android.os.Looper;
 import android.os.Message;
-import android.os.MessageQueue;
-import android.util.Log;
-
-import java.lang.reflect.Field;
-import java.lang.reflect.InvocationTargetException;
-import java.lang.reflect.Method;
 
 class SystemMessageHandler extends Handler {
-
-    private static final String TAG = "SystemMessageHandler";
 
     private static final int SCHEDULED_WORK = 1;
     private static final int DELAYED_SCHEDULED_WORK = 2;
@@ -25,23 +16,12 @@
     private long mMessagePumpDelegateNative = 0;
     private long mDelayedScheduledTimeTicks = 0;
 
-    // The following members are used to detect and trace the presence of sync
-    // barriers in Android's MessageQueue. Note that this detection is
-    // experimental, temporary and intended only for diagnostic purposes.
-    private MessageQueue mMessageQueue;
-    private Field mMessageQueueMessageField;
-    private Field mMessageTargetField;
-    private boolean mQueueHasSyncBarrier;
-    private long mSyncBarrierTraceId;
-
     private SystemMessageHandler(long messagePumpDelegateNative) {
         mMessagePumpDelegateNative = messagePumpDelegateNative;
-        tryEnableSyncBarrierDetection();
-     }
+    }
 
     @Override
     public void handleMessage(Message msg) {
-        updateWhetherQueueHasBlockingSyncBarrier();
         if (msg.what == DELAYED_SCHEDULED_WORK) {
             mDelayedScheduledTimeTicks = 0;
         }
@@ -51,8 +31,6 @@
     @SuppressWarnings("unused")
     @CalledByNative
     private void scheduleWork() {
-        updateWhetherQueueHasBlockingSyncBarrier();
-        if (mQueueHasSyncBarrier)
TraceEvent.instant("SystemMessageHandler:immediateWorkBlocked");
         sendEmptyMessage(SCHEDULED_WORK);
     }
 
@@ -63,98 +41,15 @@
             removeMessages(DELAYED_SCHEDULED_WORK);
         }
         mDelayedScheduledTimeTicks = delayedTimeTicks;
-        updateWhetherQueueHasBlockingSyncBarrier();
-        if (mQueueHasSyncBarrier)
TraceEvent.instant("SystemMessageHandler:delayedWorkBlocked");
         sendEmptyMessageDelayed(DELAYED_SCHEDULED_WORK, millis);
     }
 
     @SuppressWarnings("unused")
     @CalledByNative
     private void removeAllPendingMessages() {
-        updateWhetherQueueHasBlockingSyncBarrier();
         removeMessages(SCHEDULED_WORK);
         removeMessages(DELAYED_SCHEDULED_WORK);
     }
-
-    private void updateWhetherQueueHasBlockingSyncBarrier() {
-        if (mMessageQueue == null) return;
-        // As barrier detection is only used for tracing, early out when
tracing
-        // is disabled to avoid any potential performance penalties.
-        if (!TraceEvent.enabled()) {
-            mQueueHasSyncBarrier = false;
-            return;
-        }
-        Message queueHead = (Message)getField(mMessageQueue,
mMessageQueueMessageField);
-        setqueueHasSyncBarrier(isSyncBarrierMessage(queueHead));
-    }
-
-    private boolean isSyncBarrierMessage(Message message) {
-        if (message == null) return false;
-        // Sync barrier messages have null targets.
-        return getField(message, mMessageTargetField) == null;
-    }
-
-    private void tryEnableSyncBarrierDetection() {
-        assert mMessageQueue == null;
-
-        boolean success = false;
-        try {
-            Method getQueueMethod = Looper.class.getMethod("getQueue", new
Class[]{});
-            mMessageQueue = (MessageQueue)getQueueMethod.invoke(getLooper());
-
-            mMessageQueueMessageField =
mMessageQueue.getClass().getDeclaredField("mMessages");
-            mMessageQueueMessageField.setAccessible(true);
-
-            mMessageTargetField = Message.class.getDeclaredField("target");
-            mMessageTargetField.setAccessible(true);
-
-            mSyncBarrierTraceId = hashCode();
-
-            success = true;
-        } catch (NoSuchMethodException e) {
-            Log.e(TAG, "Failed to load method: " + e);
-        } catch (NoSuchFieldException e) {
-            Log.e(TAG, "Failed to load field: " + e);
-        } catch (InvocationTargetException e) {
-            Log.e(TAG, "Failed invocation: " + e);
-        } catch (IllegalAccessException e) {
-            Log.e(TAG, "Illegal access to reflected invocation: " + e);
-        } catch (IllegalArgumentException e) {
-            Log.e(TAG, "Illegal argument to reflected invocation: " + e);
-        } catch (RuntimeException e) {
-            Log.e(TAG, e.toString());
-        } finally {
-            if (!success) disableSyncBarrierDetection();
-        }
-    }
-
-    private void disableSyncBarrierDetection() {
-        Log.e(TAG, "Unexpected error with sync barrier detection, disabling.");
-        mMessageQueue = null;
-        mMessageQueueMessageField = null;
-        mMessageTargetField = null;
-        setqueueHasSyncBarrier(false);
-    }
-
-    private void setqueueHasSyncBarrier(boolean queueHasSyncBarrier) {
-        if (queueHasSyncBarrier == mQueueHasSyncBarrier) return;
-        mQueueHasSyncBarrier = queueHasSyncBarrier;
-        if (mQueueHasSyncBarrier) {
-            TraceEvent.startAsync("SyncBarrier", mSyncBarrierTraceId);
-        } else {
-            TraceEvent.finishAsync("SyncBarrier", mSyncBarrierTraceId);
-        }
-    }
-
-    private Object getField(Object object, Field field) {
-        try {
-            return field.get(object);
-        } catch (IllegalAccessException e) {
-            Log.e(TAG, "Failed field access: " + e);
-            disableSyncBarrierDetection();
-        }
-        return null;
-     }
 
     @CalledByNative
     private static SystemMessageHandler create(long messagePumpDelegateNative)
{

[commit-bot: I haz the power, 2014-11-13 16:55:58]

The CQ bit was unchecked by commit-bot@chromium.org

[jdduke (slow), 2014-11-13 17:31:03]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-11-13 17:31:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/726623002/40001

[commit-bot: I haz the power, 2014-11-13 17:32:10]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-11-13 17:32:54]

Patchset 2 (id:??) landed as
https://crrev.com/adefc40cb9652a2ea046bbdbef223d881f4a7463
Cr-Commit-Position: refs/heads/master@{#304040}