Source/core/loader/MixedContentChecker.h - Issue 726563004: MixedContentChecker should not log blocked preload requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/MixedContentChecker.h

Issue 726563004: MixedContentChecker should not log blocked preload requests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/fetch/ResourceFetcher.cpp ('K') | « Source/core/fetch/ResourceFetcher.cpp ('k') | Source/core/loader/MixedContentChecker.cpp » ('j') | Source/core/loader/MixedContentChecker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/MixedContentChecker.h

diff --git a/Source/core/loader/MixedContentChecker.h b/Source/core/loader/MixedContentChecker.h

index c30a59e6af49f7eb84faf253c5a79c5019cc513a..b87384eae51de9cead0398e56b7287a2a5361cf2 100644

--- a/Source/core/loader/MixedContentChecker.h

+++ b/Source/core/loader/MixedContentChecker.h

@@ -48,7 +48,8 @@ class MixedContentChecker final {

public:

explicit MixedContentChecker(LocalFrame*);

- static bool shouldBlockFetch(LocalFrame*, const ResourceRequest&, const KURL&);

+ enum SuppressLogType { LogIfBlocked, SuppressLog };

Mike West 2014/11/14 08:08:17 Please use the same language as we use in CSP: htt

kouhei (in TOK) 2014/11/14 09:19:31 Done.

+ static bool shouldBlockFetch(LocalFrame*, const ResourceRequest&, const KURL&, SuppressLogType);

bool canDisplayInsecureContent(SecurityOrigin* securityOrigin, const KURL& url) const

{