Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 726563002: Do not retry intentionally failing tests on browsers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index a98d777e038cc0d9565421affa4e25bda0aea530..8f9e9966f0ce6179855da6506a4b77ea005a67ed 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1353,7 +1353,8 @@ class StandardTestSuite extends TestSuite {
CommandBuilder.instance.getBrowserTestCommand(
runtime,
fullHtmlPath,
- configuration));
+ configuration,
+ !isNegative(info)));
}
// Create BrowserTestCase and queue it.
@@ -1436,7 +1437,8 @@ class StandardTestSuite extends TestSuite {
runtime,
fullHtmlPath,
configuration,
- info.expectedMessages));
+ info.expectedMessages,
+ !isNegative(info)));
String testDisplayName = '$suiteName/$testName';
var testCase = new BrowserTestCase(
testDisplayName,
@@ -1843,7 +1845,7 @@ class PKGTestSuite extends StandardTestSuite {
var fullPath = _createUrlPathFromFile(customHtmlPath);
commands.add(CommandBuilder.instance.getBrowserTestCommand(
- runtime, fullPath, configuration));
+ runtime, fullPath, configuration, !isNegative(info)));
String testDisplayName = '$suiteName/$testName';
enqueueNewTestCase(new BrowserTestCase(testDisplayName,
commands,
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698