Source/bindings/scripts/v8_interface.py - Issue 726553002: bindings: Retires [Custom=Wrap].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 726553002: bindings: Retires [Custom=Wrap]. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 96c83e4bcc2226bcbbde3eb501ebf1f78cccdfa7..d4985ea3b210450bf5de511174302ec3f511a624 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -166,7 +166,7 @@ def interface_context(interface):

# [NotScriptWrappable]

is_script_wrappable = 'NotScriptWrappable' not in extended_attributes

- # [Custom=Wrap], [SetWrapperReferenceFrom]

+ # [SetWrapperReferenceFrom]

has_visit_dom_wrapper = (

has_extended_attribute_value(interface, 'Custom', 'VisitDOMWrapper') or

reachable_node_function or

@@ -192,7 +192,6 @@ def interface_context(interface):

interface.name != 'EventTarget'),

'has_custom_legacy_call_as_function': has_extended_attribute_value(interface, 'Custom', 'LegacyCallAsFunction'), # [Custom=LegacyCallAsFunction]

'has_custom_to_v8': has_extended_attribute_value(interface, 'Custom', 'ToV8'), # [Custom=ToV8]

- 'has_custom_wrap': has_extended_attribute_value(interface, 'Custom', 'Wrap'), # [Custom=Wrap]

'has_partial_interface': len(interface.partial_interfaces) > 0,

'has_visit_dom_wrapper': has_visit_dom_wrapper,

'header_includes': header_includes,

« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »