Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 726543008: [ServiceWorker] Fix ASSERT failure in DocumentThreadableLoader::handleResponse(). (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
Mike West, yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, tyoshino+watch_chromium.org, nhiroki, falken, kinuko+serviceworker, gavinp+loader_chromium.org, horo+watch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Fix ASSERT failure in DocumentThreadableLoader::handleResponse(). In current implementation, ASSERT(!m_fallbackRequestForServiceWorker) in DocumentThreadableLoader::handleResponse fails while loading the data URL or sending OPTIONS request using XHR. This is because: - m_fallbackRequestForServiceWorker is set in the constructor of DocumentThreadableLoader, - But the request is not handled by the ServiceWorker. - So DocumentThreadableLoader::handleResponse() is called with response.wasFetchedViaServiceWorker() == false. This cl add the check of the URL scheme and the HTTP method in the constructor of DocumentThreadableLoader. BUG=434603 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html View 2 chunks +44 lines, -0 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
horo
yhirano@ Could you please review this?
6 years, 1 month ago (2014-11-19 12:42:29 UTC) #2
yhirano
lgtm
6 years, 1 month ago (2014-11-19 13:29:11 UTC) #3
horo
mkwst@ Could you please review this?
6 years, 1 month ago (2014-11-19 13:32:27 UTC) #5
Mike West
LGTM, thanks!
6 years, 1 month ago (2014-11-19 16:20:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726543008/1
6 years, 1 month ago (2014-11-19 21:01:39 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 21:44:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185624

Powered by Google App Engine
This is Rietveld 408576698