Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 726513002: [turbofan] Smartify the GraphReducer. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Smartify the GraphReducer. Don't use the generic algorithm, but instead start going into the direction of ControlReducer, using a stack plus a revisit queue to not miss any more possibilities for reductions anymore. TEST=cctest,unittests R=dcarney@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/f047507370634155113d78685372630a230613cf Committed: https://chromium.googlesource.com/v8/v8/+/6e148989a4227a5290a7f8ca72c71f5740870afe Committed: https://chromium.googlesource.com/v8/v8/+/5934656921a848cb112c2e5e146d5c0bf9d8904a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix release. #

Patch Set 3 : Fixes #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -77 lines) Patch
M src/compiler/graph-reducer.h View 1 2 1 chunk +22 lines, -3 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 2 1 chunk +156 lines, -46 lines 0 comments Download
M src/compiler/pipeline.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M src/zone-containers.h View 1 2 2 chunks +21 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 1 2 14 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer
6 years, 1 month ago (2014-11-13 10:35:26 UTC) #1
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-13 10:38:42 UTC) #2
dcarney
lgtm https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h File src/zone-containers.h (right): https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h#newcode52 src/zone-containers.h:52: ZoneDeque(int size, Zone* zone) i really think we ...
6 years, 1 month ago (2014-11-13 10:42:15 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h File src/zone-containers.h (right): https://codereview.chromium.org/726513002/diff/1/src/zone-containers.h#newcode52 src/zone-containers.h:52: ZoneDeque(int size, Zone* zone) Ups that was dead code ...
6 years, 1 month ago (2014-11-13 10:50:34 UTC) #4
Benedikt Meurer
Committed patchset #4 (id:60001) manually as f047507370634155113d78685372630a230613cf (tree was closed).
6 years, 1 month ago (2014-11-13 11:34:22 UTC) #5
Benedikt Meurer
Committed patchset #4 (id:60001) manually as 6e148989a4227a5290a7f8ca72c71f5740870afe (presubmit successful).
6 years, 1 month ago (2014-11-14 08:00:45 UTC) #6
Benedikt Meurer
6 years, 1 month ago (2014-11-17 12:12:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
5934656921a848cb112c2e5e146d5c0bf9d8904a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698