Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 726503002: [ServiceWorker] Stop using FetchRequestData::Context (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Stop using FetchRequestData::Context This is duplication of WebURLRequest::RequestContext. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/modules/serviceworkers/FetchRequestData.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
horo
nhiroki@ Could you please review?
6 years, 1 month ago (2014-11-13 08:13:25 UTC) #2
nhiroki
LGTM
6 years, 1 month ago (2014-11-13 08:35:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726503002/1
6 years, 1 month ago (2014-11-13 08:45:09 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 09:21:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185278

Powered by Google App Engine
This is Rietveld 408576698