Instrumented libraries: fix libpci3 build on Trusty.

third_party/instrumented_libraries/download_build_install.py

 #!/usr/bin/python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Downloads, builds (with instrumentation) and installs shared libraries."""
 
 import argparse
 import os
 import platform
+import re
 import shlex
 import shutil
 import subprocess
 import sys
 
 class ScopedChangeDirectory(object):
   """Changes current working directory and restores it back automatically."""
 
   def __init__(self, path):
     self.path = path
@@ skipping 141 matching lines @@
   ]
   shell_call('make -j%s install %s' %
              (parsed_arguments.jobs, ' '.join(install_args)),
              parsed_arguments.verbose, environment)
 
 
 def libpci3_make_install(parsed_arguments, environment, install_prefix):
   # pciutils doesn't have a configure script
   # This build script follows debian/rules.
 
+  # Find out the package version. We'll use this when creating symlinks.
+  dir_name = os.path.split(os.getcwd())[-1]
+  match = re.match('pciutils-(\d+\.\d+\.\d+)', dir_name)
+  if match is None:
+    raise Exception(
+        'Unable to guess libpci3 version from directory name: %s' %  dir_name)
+  version = match.group(1)
+
   # `make install' will create a "$(DESTDIR)-udeb" directory alongside destdir.
   # We don't want that in our product dir, so we use an intermediate directory.
   destdir = '%s/debian/pciutils' % os.getcwd()
   make_args = [
       '%s="%s"' % (name, environment[name])
       for name in['CC', 'CXX', 'CFLAGS', 'CXXFLAGS', 'LDFLAGS']]
   make_args.append('SHARED=yes')
+  # pciutils-3.2.1 (Trusty) fails to build due to unresolved libkmod symbols.
+  # The binary package has no dependencies on libkmod, so it looks like it was
+  # actually built without libkmod support.
+  make_args.append('LIBKMOD=no')
   paths = [
       'LIBDIR=/lib/',
       'PREFIX=/usr',
       'SBINDIR=/usr/bin',
       'IDSDIR=/usr/share/misc',
   ]
   install_args = ['DESTDIR=%s' % destdir]
   run_shell_commands([
       'mkdir -p %s-udeb/usr/bin' % destdir,
       'make -j%s %s' % (parsed_arguments.jobs, ' '.join(make_args + paths)),
       'make -j%s %s install' % (
           parsed_arguments.jobs,
           ' '.join(install_args + paths))],
                      parsed_arguments.verbose, environment)
   # Now move the contents of the temporary destdir to their final place.
   run_shell_commands([
       'cp %s/* %s/ -rd' % (destdir, install_prefix),
       'install -m 644 lib/libpci.so* %s/lib/' % install_prefix,
-      'ln -sf libpci.so.3.1.8 %s/lib/libpci.so.3' % install_prefix],
+      'ln -sf libpci.so.%s %s/lib/libpci.so.3' % (version, install_prefix)],
                      parsed_arguments.verbose, environment)
 
 
 def build_and_install(parsed_arguments, environment, install_prefix):
   if parsed_arguments.build_method == 'destdir':
     destdir_configure_make_install(
         parsed_arguments, environment, install_prefix)
   elif parsed_arguments.build_method == 'custom_nss':
     nss_make_and_copy(parsed_arguments, environment, install_prefix)
   elif parsed_arguments.build_method == 'custom_libcap':
@@ skipping 153 matching lines @@
   os.chdir(get_script_absolute_path())
   # Ensure all build dependencies are installed.
   if parsed_arguments.check_build_deps:
     check_package_build_dependencies(parsed_arguments.package)
 
   download_build_install(parsed_arguments)
 
 
 if __name__ == '__main__':
   main()