Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 726423002: Hydrogen should recognize literal smi arrays as fast literals. (Closed)

Created:
6 years, 1 month ago by mvstanton
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Hydrogen should recognize literal smi arrays as fast literals. R=hpayer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/78cf188e18a3204b04c3c0293480b1dacf446e8f

Patch Set 1 #

Patch Set 2 : Test failure revealed forgotten requirement with dependencies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -44 lines) Patch
M src/hydrogen.cc View 1 6 chunks +11 lines, -17 lines 0 comments Download
M src/objects.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M src/objects.cc View 1 1 chunk +26 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Hi Hannes, P to the TAL? Thx! --Michael
6 years, 1 month ago (2014-11-17 13:04:12 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 1 month ago (2014-11-17 13:06:22 UTC) #2
mvstanton
Thanks Hannes, as discussed, I need to continue enforcing the regime of deopt on transition ...
6 years, 1 month ago (2014-11-17 16:13:08 UTC) #3
Hannes Payer (out of office)
still LGTM
6 years, 1 month ago (2014-11-18 08:52:26 UTC) #4
mvstanton
6 years, 1 month ago (2014-11-18 09:28:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
78cf188e18a3204b04c3c0293480b1dacf446e8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698