build/util/lastchange.py - Issue 726413003: Make lastchange.py faster using git cat-file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/util/lastchange.py

Issue 726413003: Make lastchange.py faster using git cat-file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/util/lastchange.py

diff --git a/build/util/lastchange.py b/build/util/lastchange.py

index 28a266ddaf7ad977d37f4499076b0aa84eca19c5..d1c33e8eb01170face4ed8e8c5814285106e9beb 100755

--- a/build/util/lastchange.py

+++ b/build/util/lastchange.py

@@ -108,7 +108,7 @@ def FetchGitRevision(directory):

if not hsh:

return None

pos = ''

- proc = RunGitCommand(directory, ['show', '-s', '--format=%B', 'HEAD'])

+ proc = RunGitCommand(directory, ['cat-file', 'commit', 'HEAD'])

if proc:

output = proc.communicate()[0]

if proc.returncode == 0 and output:

« no previous file with comments | « no previous file | no next file » | no next file with comments »