Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 726373006: Fix call to run telemetry_unittests. (Closed)

Created:
6 years, 1 month ago by navabi
Modified:
6 years, 1 month ago
Reviewers:
klundberg, tonyg, jbudorick, dtu
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix call to run telemetry_unittests. BUG=384341 Committed: https://crrev.com/40c05fc136508e06093e399e47cf070cbb26414b Cr-Commit-Position: refs/heads/master@{#305035}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Share code between telemetry_perf_unittests and telemetry_unittests. #

Patch Set 3 : ignore this patch. was suppose to be a different CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
navabi
6 years, 1 month ago (2014-11-20 00:33:41 UTC) #2
tonyg
https://codereview.chromium.org/726373006/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/726373006/diff/1/build/android/buildbot/bb_device_steps.py#newcode475 build/android/buildbot/bb_device_steps.py:475: def RunTelemetryUnitTests(options): This is a copy/paste from RunTelemetryPerfUnitTests except ...
6 years, 1 month ago (2014-11-20 00:40:05 UTC) #3
navabi
PTAL
6 years, 1 month ago (2014-11-20 05:30:53 UTC) #4
dtu
lgtm
6 years, 1 month ago (2014-11-20 07:33:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726373006/20001
6 years, 1 month ago (2014-11-20 07:34:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/25432)
6 years, 1 month ago (2014-11-20 07:38:23 UTC) #9
jbudorick
b/a/buildbot lgtm I'm guessing this is because you're not on your chromium account?
6 years, 1 month ago (2014-11-20 14:53:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726373006/20001
6 years, 1 month ago (2014-11-20 17:46:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 18:10:03 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:10:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40c05fc136508e06093e399e47cf070cbb26414b
Cr-Commit-Position: refs/heads/master@{#305035}

Powered by Google App Engine
This is Rietveld 408576698