src/heap/incremental-marking.cc - Issue 726363002: Fix concurrent sweeping in predictable mode and bring --concurrent-sweeping flag back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 726363002: Fix concurrent sweeping in predictable mode and bring --concurrent-sweeping flag back. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index dde06217a2c035250df017790f2e72b01e8435de..9806b4edbdad193bbba387eda8336ff960193e07 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -936,7 +936,8 @@ intptr_t IncrementalMarking::Step(intptr_t allocated_bytes,

if (state_ == SWEEPING) {

if (heap_->mark_compact_collector()->sweeping_in_progress() &&

- heap_->mark_compact_collector()->IsSweepingCompleted()) {

+ (heap_->mark_compact_collector()->IsSweepingCompleted() ||

+ !FLAG_concurrent_sweeping)) {

heap_->mark_compact_collector()->EnsureSweepingCompleted();

}

if (!heap_->mark_compact_collector()->sweeping_in_progress()) {

« no previous file with comments | « src/flag-definitions.h ('k') | src/heap/mark-compact.cc » ('j') | no next file with comments »