Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 726313006: Fix GetImgFingerprint for small files. (Closed)

Created:
6 years, 1 month ago by csharp
Modified:
6 years ago
CC:
chromium-reviews, Sigurður Ásgeirsson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix GetImgFingerprint for small files. %06x was incorrectly adding leading zeros for small files, the value should just be %x. BUG= Committed: https://crrev.com/55e00b641ba4fcb347f9b8821531682843c59f27 Cr-Commit-Position: refs/heads/master@{#304430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/symsrc/img_fingerprint.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
csharp
Fixing as discussed in the email thread. According to the code search, this is the ...
6 years, 1 month ago (2014-11-17 16:13:00 UTC) #2
Sigurður Ásgeirsson
lgtm
6 years, 1 month ago (2014-11-17 16:15:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726313006/1
6 years, 1 month ago (2014-11-17 16:16:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-17 17:05:32 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55e00b641ba4fcb347f9b8821531682843c59f27 Cr-Commit-Position: refs/heads/master@{#304430}
6 years, 1 month ago (2014-11-17 17:06:13 UTC) #8
brucedawson
It's already checked in, but, lgtm
6 years, 1 month ago (2014-11-17 18:23:12 UTC) #10
chrisha
Awesome, lgtm!
6 years, 1 month ago (2014-11-17 18:24:31 UTC) #11
brucedawson
6 years ago (2014-12-12 00:32:27 UTC) #12
Message was sent while issue was closed.
This fix didn't work because this is not actually the copy of img_fingerprint.py
which our official builds use. csharp@ found the right file and re-did the same
fix. I just verified that it works. Details and the final fix are here:

https://chromereviews.googleplex.com/130777013/

Powered by Google App Engine
This is Rietveld 408576698