Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 7263: Fixed bug 114 (Closed)

Created:
12 years, 2 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fixed bug 114

Patch Set 1 #

Patch Set 2 : Added some more tests and fixed an issue they revealed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M src/runtime.cc View 1 2 chunks +9 lines, -3 lines 1 comment Download
A test/mjsunit/regress/regress-114.js View 1 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Christian Plesner Hansen
12 years, 2 months ago (2008-10-13 08:36:03 UTC) #1
Christian Plesner Hansen
I've made enough changes to this changelist that I thought maybe you better take a ...
12 years, 2 months ago (2008-10-14 08:07:37 UTC) #2
Erik Corry
12 years, 2 months ago (2008-10-14 09:01:52 UTC) #3
LGTM

http://codereview.chromium.org/7263/diff/203/5
File src/runtime.cc (right):

http://codereview.chromium.org/7263/diff/203/5#newcode2162
Line 2162: next_length = mapping->get(next, 0, chars);
Missing comment here to explain why 0 is OK.

Powered by Google App Engine
This is Rietveld 408576698