Eliminate AutofillWebDataService::FromBrowserContext().

chrome/browser/webdata/web_data_service_factory.h

Index: chrome/browser/webdata/web_data_service_factory.h
diff --git a/chrome/browser/webdata/web_data_service_factory.h b/chrome/browser/webdata/web_data_service_factory.h
index cb80c23be977fb5b5e37df87dda74454c8f8434d..12e5c377ef19ddd26b9374170b65a8033cc79e08 100644
--- a/chrome/browser/webdata/web_data_service_factory.h
+++ b/chrome/browser/webdata/web_data_service_factory.h
@@ -62,6 +62,15 @@ class WebDataServiceFactory : public BrowserContextKeyedServiceFactory {
   static WebDataServiceWrapper* GetForProfileIfExists(
       Profile* profile, Profile::ServiceAccessType access_type);
 
+  // Returns the |AutofillWebDataService| associated with the |profile| (as
+  // |AutofillWebDataService| is shared with iOS, it cannot know directly about
+  // BrowserContext/Profile and thus cannot define this getter itself).

[Peter Kasting, 2013/11/19 19:14:15]

Nit: Just:

  // Returns the AutofillWebDataService associated with the |profile|.

Once AutofillWebDataService is a layered component it won't even be able to
compile if someone adds a browser context dependency, so there's no need for the
rest of the comment.

[blundell, 2013/12/02 16:11:00]

Done.

+  // |access_type| is either EXPLICIT_ACCESS or IMPLICIT_ACCESS
+  // (see its definition).
+  static scoped_refptr<autofill::AutofillWebDataService>

[Peter Kasting, 2013/11/19 19:14:15]

I thought our current recommendation on scoped_refptr was to return it by raw
pointer until we'd eliminated the implicit refptr->raw pointer conversion.

[blundell, 2013/12/02 16:11:00]

Yes, I filed crbug.com/321059. I'd rather keep those changes separate from this
refactoring to help ensure that this CL doesn't introduce any functional changes
(note that the API I'm moving away from is returning a scoped_refptr).

On 2013/11/19 19:14:15, Peter Kasting wrote:

+      GetAutofillWebDataForProfile(Profile* profile,
+                                   Profile::ServiceAccessType access_type);
+
   static WebDataServiceFactory* GetInstance();
 
  private: